change license to Apache 2.0
In line with the planned license change in sbi, I suggest to change the license of pyknos to Apache 2.0 as well. Please see https://github.com/sbi-dev/sbi/pull/997 for details.
Please indicate your approval of this change by approving this PR or by commenting below.
Thanks 🙏
@conormdurkan we need your approval as well because it's all based on your MDN implementation :)
@harry-fuyu we kindly ask for your approval because you contributed during your internship with us.
Hi Jan,
Sorry for the late reply, of course I agree with the change. Hope all is well with you!
Best regards, Harry
On Tue, 2 Apr 2024 at 20:26, Jan @.***> wrote:
@harry-fuyu https://github.com/harry-fuyu we kindly ask for your approval because you contributed during your internship with us.
— Reply to this email directly, view it on GitHub https://github.com/sbi-dev/pyknos/pull/28#issuecomment-2031908948, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJH4AYTX7HTVBW4EFQSOELY3KPX5AVCNFSM6AAAAABFTJAIKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZRHEYDQOJUHA . You are receiving this because you were mentioned.Message ID: @.***>
Hi Harry,
thanks for your reply! While you are at it, could you please also approve the change in SBI? https://github.com/sbi-dev/sbi/pull/997
Thanks, Jan On Apr 2, 2024 at 14:52 +0200, Harry Fu Yu @.***>, wrote:
Hi Jan,
Sorry for the late reply, of course I agree with the change. Hope all is well with you!
Best regards, Harry
On Tue, 2 Apr 2024 at 20:26, Jan @.***> wrote:
@harry-fuyu https://github.com/harry-fuyu we kindly ask for your approval because you contributed during your internship with us.
— Reply to this email directly, view it on GitHub https://github.com/sbi-dev/pyknos/pull/28#issuecomment-2031908948, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJH4AYTX7HTVBW4EFQSOELY3KPX5AVCNFSM6AAAAABFTJAIKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZRHEYDQOJUHA . You are receiving this because you were mentioned.Message ID: @.***>
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were assigned.Message ID: @.***>
Hi Jan,
Done! I didn’t get email notification for the mention, sorry for the delay!
Best regards, Harry
On Tue, 2 Apr 2024 at 20:58, Jan @.***> wrote:
Hi Harry,
thanks for your reply! While you are at hit, could you please also approve the change in SBI? https://github.com/sbi-dev/sbi/pull/997
Thanks, Jan On Apr 2, 2024 at 14:52 +0200, Harry Fu Yu @.***>, wrote:
Hi Jan,
Sorry for the late reply, of course I agree with the change. Hope all is well with you!
Best regards, Harry
On Tue, 2 Apr 2024 at 20:26, Jan @.***> wrote:
@harry-fuyu https://github.com/harry-fuyu we kindly ask for your approval because you contributed during your internship with us.
— Reply to this email directly, view it on GitHub https://github.com/sbi-dev/pyknos/pull/28#issuecomment-2031908948, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AKJH4AYTX7HTVBW4EFQSOELY3KPX5AVCNFSM6AAAAABFTJAIKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZRHEYDQOJUHA>
. You are receiving this because you were mentioned.Message ID: @.***>
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were assigned.Message ID: @.***>
— Reply to this email directly, view it on GitHub https://github.com/sbi-dev/pyknos/pull/28#issuecomment-2031975493, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJH4AZL4YKLWL7TFC2IEPLY3KTOPAVCNFSM6AAAAABFTJAIKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZRHE3TKNBZGM . You are receiving this because you were mentioned.Message ID: @.***>
@alvorithm @jan-matthis @conormdurkan please have a look and approve the pull request if you are fine with the change.
While in general I remain a proponent of strong copyleft licenses, I also wholeheartedly share the goal to make pyknos and sbi approachable for a wider community of users and developers. Acknowledging compelling arguments made by fellow team members, I am now keen to find out in practice to what extent adopting weaker copyleft might help to that end.
Hence, I approve relicensing pyknos under the Apache 2.0 license.
@conormdurkan could you please have a look and approve the pull request if you are fine with the change.
Given that @conormdurkan agreed to the re-licensing of the code in sbi, and the code used here is actually the same code, I would opt for merging this pull request soon.
I would be fine with merging too.