libubootenv icon indicating copy to clipboard operation
libubootenv copied to clipboard

disable-lock vs. disablelock

Open jan-kiszka opened this issue 10 months ago • 4 comments

Doc says "disable-lock" (https://github.com/sbabic/libubootenv/blob/master/docs/fw_env_config.md), but this suggests "disablelock": https://github.com/sbabic/libubootenv/blob/0052cdc11ab826192fa08779266073ee132f3940/src/extended_config.c#L254. Just a drive-by finding while reading code.

jan-kiszka avatar Mar 27 '25 09:03 jan-kiszka

Thanks Jan, this is a common mistake from my side :-). I fix the doc.

sbabic avatar Mar 31 '25 14:03 sbabic

@sbabic I also found the same issue, and created a PR 2 years ago: https://github.com/sbabic/libubootenv/pull/24, may I know is the right place to create pull request here to contribute? Or is there some mail list I shall use?

I found some PRs basically were ignored.

liuming50 avatar Apr 01 '25 08:04 liuming50

I found some PRs basically were ignored.

All PRs are ignored. There is no way to disable PRs in github.

The right place to discuss and post patches is the Mailing List (from swupdate, [email protected]). But this is documented in the README

sbabic avatar Apr 01 '25 08:04 sbabic

@sbabic Arha, did not read it carefully, sorry. Will send patches by mails and close my MRs.

liuming50 avatar Apr 01 '25 09:04 liuming50