httpi icon indicating copy to clipboard operation
httpi copied to clipboard
verified publisher icon savonrb

Fix SSL protocols supported by curb adapter

Open 907th opened this issue 7 years ago • 8 comments

  • Use Curl:: consts instead of magic numbers.
  • Fix invalid values of TLSv1_1 and TLSv1_2 constants.
  • Add support for TLSv1_0.

907th avatar Dec 13 '18 12:12 907th

Coverage Status

Coverage increased (+0.2%) to 97.3% when pulling cee2b9616d23f7e1d932f4c11a8615e2da3a6450 on 907th:fix_curb_ssl_versions into 2fbd6b14a0a04ed21572251580a9a4c987396e4b on savonrb:master.

coveralls avatar Dec 13 '18 13:12 coveralls

Coverage Status

Coverage increased (+0.2%) to 97.3% when pulling cee2b9616d23f7e1d932f4c11a8615e2da3a6450 on 907th:fix_curb_ssl_versions into 2fbd6b14a0a04ed21572251580a9a4c987396e4b on savonrb:master.

coveralls avatar Dec 13 '18 13:12 coveralls

Coverage Status

Coverage increased (+0.2%) to 97.3% when pulling cee2b9616d23f7e1d932f4c11a8615e2da3a6450 on 907th:fix_curb_ssl_versions into 2fbd6b14a0a04ed21572251580a9a4c987396e4b on savonrb:master.

coveralls avatar Dec 13 '18 13:12 coveralls

Coverage Status

Coverage increased (+0.2%) to 97.3% when pulling cee2b9616d23f7e1d932f4c11a8615e2da3a6450 on 907th:fix_curb_ssl_versions into 2fbd6b14a0a04ed21572251580a9a4c987396e4b on savonrb:master.

coveralls avatar Dec 13 '18 13:12 coveralls

Coverage Status

Coverage increased (+0.2%) to 97.3% when pulling cee2b9616d23f7e1d932f4c11a8615e2da3a6450 on 907th:fix_curb_ssl_versions into 2fbd6b14a0a04ed21572251580a9a4c987396e4b on savonrb:master.

coveralls avatar Dec 13 '18 13:12 coveralls

Hi @907th. Thanks for opening this PR. Seems good to merge.

rogerleite avatar Jan 21 '19 11:01 rogerleite

Forgot this PR sorry. This code is going to conflict with https://github.com/savonrb/httpi/pull/208. 🤔

rogerleite avatar Jul 07 '20 15:07 rogerleite

Can you please rebase on master? Thanks!

ioquatix avatar Oct 06 '21 03:10 ioquatix