save-cli

save-cli copied to clipboard

Right now we have `com.saveourtool.save.core.logging.log` which implements logging. We also reuse it in save-cloud, wrapping it into `com.saveourtool.save.agent.utils.logCustom`. Suggestion is to process option to append thread-id on save-cli side. Kotlin...

sanyavertolet

Automatize `yarn.lock` or remove it

2

> shouldn't it be automatically? @nulls we have it as a separate task in save-cloud, but we don't have such in save-cli honestly, I don't understand why we need `yarn.lock`...

nulls

https://github.com/saveourtool/save-cli/actions/runs/4466559035 It's not clear does it lead to failure or not: We have successful job with warning: https://github.com/saveourtool/save-cli/actions/runs/4466559035/jobs/7845287700. ``` Request GET /search/issues?q=type%3Apr+repo%3A%22saveourtool%2Fsave-cli%22+4cd51c0fc9085f8b7b2cff6f5b1c922777591e72&per_page=100 failed with 403: Forbidden ``` We have job...

nulls

SARIF: raise an exception whenever an absolute non-`file:` URI is encountered

1

Example: ```json "artifactLocation": { "uri": "https://github.com/ossf/scorecard/blob/main/actions/entrypoint.sh" } ``` When `save-cli` is used as an executable (rather than as a library), a specific exit code should be returned — see #467

0x6675636b796f75676974687562

Properly configure detekt

1

It seems, that it is not working properly, ex, how it could be configured: [okio-extras#detekt](https://github.com/saveourtool/okio-extras/blob/4f07d23eef1bdd2bfc77bed7987bd84068470bb1/buildSrc/src/main/kotlin/com/saveourtool/buildutils/DetektConfiguration.kt)

kgevorkyan

Add info about manual actions, which are required for releasing

kgevorkyan

Support inline fixers for fix and warn plugin

3

We need to support the following LIT fixers: https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/test/clang-tidy/checkers/abseil-time-comparison.cpp ``` // CHECK-MESSAGES: [[@LINE-1]]:7: warning: perform comparison in the time domain [abseil-time-comparison] // CHECK-FIXES: absl::FromUnixSeconds(x)

orchestr7

We can also operate with expected fixes by sarif files: for example. in situation, when tool make fixes in place, but user provided expected fixes not in files directly, but...

kgevorkyan

All cases, or most of them should be documented

kgevorkyan

SAVE shouldn't mutate sources it operates on

1

Now after FixPlugin execution sources have different line separators (`\r\n` becomes `\n`)

petertrr