wtfpython icon indicating copy to clipboard operation
wtfpython copied to clipboard

Accessibility: image background and alt description

Open ariasuni opened this issue 7 years ago • 8 comments

  • When reading the Markdown file with an application with dark background, or when using dark background in Github (with browser modules etc.), somes images are not legible.
  • Images doesn’t have an alt= for people using screen reader (I can do that if you want).

ariasuni avatar Feb 28 '18 12:02 ariasuni

When reading the Markdown file with an application with dark background, or when using dark background in Github (with browser modules etc.), somes images are not legible.

I see, that's probably because some images have a transparent background and black outlines (which kind of mixes with dark themes). Having a white background should fix this I guess, what do you think?

Images doesn’t have an alt= for people using screen reader (I can do that if you want).

Ah, that's bad. I'd appreciate if you'd like to fix this :)

satwikkansal avatar Feb 28 '18 20:02 satwikkansal

I figured I'd throw my hat in here -- I wouldn't mind tackling this issue (following the ./CONTRIBUTING.md guide). ^.^

contrastellar avatar Jun 06 '22 19:06 contrastellar

Hey @Contrastellar, sure, would appreciate your help! :)

satwikkansal avatar Jun 07 '22 04:06 satwikkansal

Just noticing this again, more than 4 years later, oops.

Having a white background should fix this I guess, what do you think?

Some pictures having a kind of greyish background, that could be generalized.

Ah, that's bad. I'd appreciate if you'd like to fix this :)

Unfortunately I don’t have much time, but hopefully @satwikkansal can do that :slightly_smiling_face:

ariasuni avatar Jun 07 '22 15:06 ariasuni

I'll be happy to throw something together for this! ^-^

contrastellar avatar Jun 07 '22 21:06 contrastellar

Just noticing this again, more than 4 years later, oops.

Time doesn't exist during the pandemic, its okay!

Having a white background should fix this I guess,

I picked something lighter than the background of my GitHub, and something not super bright eitehr

Before -- image

After -- image

If this looks about to what @ariasuni had in mind, I wouldn't mind someone taking a look at the Alt text on my fork before i submit my PR. ^^

contrastellar avatar Jun 07 '22 22:06 contrastellar

I love the alt-texts! However, the images are unreadable on the light theme now :) image

satwikkansal avatar Jun 08 '22 04:06 satwikkansal

Oh wack. I'm about to go out of town this weekend, but I'll take a peek at it when I get back. ^^

contrastellar avatar Jun 10 '22 15:06 contrastellar