ficsit-cli icon indicating copy to clipboard operation
ficsit-cli copied to clipboard

Avoid confusion in error message when remote server cannot be reached

Open Th3Fanbus opened this issue 2 years ago • 1 comments

What happened?

When connecting to the remote (e.g. FTP) server fails, the error message confusingly mentions failed reading FactoryGame.exe before failed to dial host since reading the file is the first operation that ficsit-cli performs on the remote:

image

Context: https://discord.com/channels/555424930502541343/555782140533407764/1194108885267656715 https://discord.com/channels/555424930502541343/555782140533407764/1194198329865801790

Version

No idea, latest at the time of writing?

What OS are you seeing the problem on?

Linux

What architecture are you seeing the problem on?

None

Relevant log output

No response

Any extra info:

No response

Th3Fanbus avatar Jan 09 '24 09:01 Th3Fanbus

Two things should be done regarding this:

  • wrapping the error text, similar to the apply scene
  • checking the connection by checking if the given directory exists (probably in i.Validate), which would give a better start to the error stack, something along the lines of failed to validate installation: failed reading {installPath}: failed acquiring connection: etc.

mircearoata avatar Jan 09 '24 09:01 mircearoata