phpbbgallery icon indicating copy to clipboard operation
phpbbgallery copied to clipboard

Versionscheck changing and .gitattributes wrong

Open chris1278 opened this issue 11 months ago • 0 comments

First a question! The .gitignore file should contain what should be ignored when downloading?

If so, this misses your goal.

The name of the file must be: .gitattributes

And the content should look like this:

.gitattributes	export-ignore
.idea	export-ignore
phpunit.xml.dist	export-ignore
.vscode	export-ignore
.codegpt	export-ignore

Furthermore, your version check is unfortunately not working.

Why don't you use GitHub for your version check file?

For example, you could create a .json file for each of the 4 extensions and then add them as ignore in the .gitattributes.

You would then have to structure the files like this:

{
	"stable": {
		"3.0": {
			"current": "3.3.0",
			"download": "https://github.com/satanasov/phpbbgallery",
			"announcement": "https://github.com/satanasov/phpbbgallery",
			"eol": null,
			"security": false
		}
	}
}

This is saved here:

https://github.com/satanasov/phpbbgallery

as gallery.json, for example.

This is saved here:

https://github.com/satanasov/phpbbgallery

as gallery.json, for example.

and the version check is entered in the composer.json like this:

{
	"name": "phpbbgallery/core",
	"type": "phpbb-extension",
	"description": "phpBB Gallery",
	"homepage": "https://github.com/satanasov/phpbbgallery",
	"version": "3.3.0",
	"time": "2023-05-26",
	"license": "GPL-2.0",
	"authors": [
		{
			"name": "Joas Schilling",
			"email": "[email protected]",
			"homepage": "http://github.com/nickvergessen",
			"role": "Main MOD Author"
		},
		{
			"name": "Stanislav Atanasov",
			"email": "[email protected]",
			"homepage": "http://www.anavaro.com",
			"role": "Extension Developer"
		}
	],
	"require": {
		"php": ">=7.1"
	},
	"extra": {
		"display-name": "phpBB Gallery",
		"soft-require": {
			"phpbb/phpbb": ">=3.3.0@dev"
		}
	},
	"version-check": {
			"host": "raw.githubusercontent.com",
			"directory": "/satanasov/phpbbgallery/master",
			"filename": "gallery.json",
			"ssl": true
		}
}

This is an example for the core. It's just a suggestion.

chris1278 avatar Feb 13 '25 16:02 chris1278