Kamil Ruczyński comments

Results 15 comments of


                                            Kamil Ruczyński

[11.x] Optimize boostrap time by using hashtable to store providers

@taylorotwell no problem, changed. I thought also about creating a new private method like getProviderByClassName to keep the behavior of the current getProvider the same. Currently, for example, it's possible...

Uuid as a string type and updates without changes in the entity

@ramsey I've just prepared a repository with a simple test to showcase this problem: https://github.com/sarven/uuid-bug-example/blob/main/tests/Repository/EntityRepositoryTest.php UUID in the entity is represented as a string, it works, but during an update...

Invalid last inserted id when the table has a trigger with insert statements in SQLSrvConnection

@Ocramius Yes, I have current MSSQL clients and PHP 7.3. I added draft PR with a simple test for this issue, I will try to make proper implementation to fix...

Invalid last inserted id when the table has a trigger with insert statements in SQLSrvConnection

@arnegroskurth I think that I created the proper solution for this problem, but it is still waiting for review. In my situation extending and modifying triggers/tables are not good practice,...

Invalid last inserted id when the table has a trigger with insert statements in SQLSrvConnection

@mherderich I checked that. It's not the problem. Without this change it will return null. Maybe it is better than returning an invalid id, but still it isn't satisfying.