Pluralize.NET icon indicating copy to clipboard operation
Pluralize.NET copied to clipboard

Update rules with missing rules from updated pluralize js library

Open Jerome2606 opened this issue 4 years ago • 2 comments

I made the comparison with the actual master branch on the JS pluralize library to update all the changes (not much at the end)

Jerome2606 avatar Aug 30 '21 09:08 Jerome2606

Hi @Jerome2606,

Thank you for taking the time to contribute - appreciate it.

Could you please provide the commit ID up to which you have synchronized the rules? Asking because I could find some extra rules in the latest master branch of the original library.

Thanks & Regards Sarath

sarathkcm avatar Aug 30 '21 12:08 sarathkcm

I'll just outline what I observed.

  1. The singular rule - [/(dg|ss|ois|lk|ok|wn|mb|th|ch|ec|oal|is|ck|ix|sser|ts|wb)ies$/i, '$1ie'], is missing .
  2. 'species' is removed from uncountables in the original library.
  3. Lots of tests added to test singular words ending in 'ie'.

Kindly update these if you were going for complete sync with the master branch of the original library.

Otherwise no worries, please just update the commit ID up to which your changes reflect in the Readme file, and as long as your changes cover all the changes & the tests up to that commit ID - I'll be happy to merge this PR.

Thanks & Regards Sarath

sarathkcm avatar Aug 30 '21 12:08 sarathkcm