Sanket Patel
Sanket Patel
sure @sinscary
Hey @TileThePlane did you try running it locally?
it is fairly simple architecture to follow. You can read some background on https://superuser.blog/distributed-file-system-python/ as this is an improvement, the problem is open ended. The goal is to have logging...
what's the `plumbum ` required for?
After reading driver's code and golang sql wrapper - driver returns badConn error if ping fails - if ping was done on a connection, connection is closed https://golang.org/src/database/sql/sql.go?s=50229:50282#L1914 so most...
I think you are right. Connection obtained here https://github.com/sanketplus/go-mysql-lock/blob/master/locker_client.go#L59 is not closed if there is any issue with query execution or return code is unexpected. More than happy to review...
Slightly unrelated but we are not using connection pool here, rather we fetch/create an explicit connection and close it manually https://pkg.go.dev/database/sql#Conn. Since a lock is held by a db connection,...
apologies for the delayed response, I got busy with certain life events :) @vanhuycntt doing just `defer dbConn.Close()` in case of error should be okay. @ankur-a since a lock is...
Looks great @joshvarner! :D Since you already tested this with vitess, can you also mention that in `Compatibility` section in docs?
much thanks @joshvarner 🙌