MxGraph icon indicating copy to clipboard operation
MxGraph copied to clipboard

!!!FEATURE: Neos 9.0 compatible

Open markusguenther opened this issue 10 months ago • 5 comments

Making the Backend part and Neos-UI part Neos 9.0 compatible. This is a followup of @Jan3k3y PR!

markusguenther avatar Apr 02 '25 23:04 markusguenther

Fixed the error in https://github.com/sandstorm/MxGraph/pull/31/commits/920bca49b7f0fba9bea3e7c71f0f2bffaa13faa8 But still dont find the Nodes. So will ask for help here.

markusguenther avatar Apr 02 '25 23:04 markusguenther

I found the problem and made a mistake using the Graph. Now I can easily find diagrams and reuse them. And guess what? The UI errors are also gone!

https://github.com/user-attachments/assets/b0e5e239-9004-4a91-8211-639bd5542a15

markusguenther avatar Apr 03 '25 09:04 markusguenther

When Neos 9 is released we can adjust the beta20 constraint and hope it is ok that I use LazyDataSource already in a new major, as it will be a major version for 9.0 I bet.

markusguenther avatar Apr 03 '25 09:04 markusguenther

FYI: I'm working on it over here and will commit to this PR when I'm done: https://github.com/JamesAlias/MxGraph/tree/neos9

I could spam my WIP commits here, but I thought I keep this PR clean for now^^

Easy way to see changes: https://github.com/markusguenther/MxGraph/compare/neos9...JamesAlias:MxGraph:neos9

JamesAlias avatar Apr 25 '25 14:04 JamesAlias

@markusguenther I created a PR with all the fixes and adjustments: https://github.com/markusguenther/MxGraph/pull/1

I am not sure about using inline styles for alignment, but it works.

There are 2 TODOs that can be removed, but I feel like the PropertyValuesToWrite ValueObject would be easier to handle if it would provide the two functions:

  • function hasProperty(PropertyName $propertyName): bool
  • function getProperty(PropertyName $propertyName): mixed

JamesAlias avatar Apr 30 '25 10:04 JamesAlias

Closed in favour of #32

markusguenther avatar May 21 '25 06:05 markusguenther