phaser-plugin-inspector icon indicating copy to clipboard operation
phaser-plugin-inspector copied to clipboard

Update Tweakpane peer dependency to support version 4.x

Open lifeinchords opened this issue 1 year ago • 3 comments

hey @samme !

I'm currently using phaser-plugin-inspector in a project where we've upgraded to Tweakpane 4.0.4. However, the current peer dependency in phaser-plugin-inspector is set to "tweakpane": "^3.1.0", which is causing conflicts in our dependency resolution.

Could you please consider updating the peer dependency to include Tweakpane 4.x? This would allow users to take advantage of the latest features and improvements in Tweakpane while still using phaser-plugin-inspector.

Thank you for all your help with Phaser

lifeinchords avatar Sep 29 '24 09:09 lifeinchords

Hi, thanks. I think I see some challenges with this:

  • Need to rewrite ~244 monitors to use addBinding() etc. Maybe Copilot can help.
  • Tweakpane v4 has no global so it would be impossible to use the Quick load snippet (for Labs or the Sandbox) or the Load from console snippet.
  • I'm not sure how the plugin could access Tweakpane in the browser without adding an import map or globalizing Tweakpane's exports. I guess the plugin could bundle Tweakpane instead.

samme avatar Sep 29 '24 14:09 samme

Thanks for the detailed reply..that sounds like a fair bit of work, I thought it might be an easy change.

I took a different direction in the meantime with another stack.. hope to hop back on this proj soon

lifeinchords avatar Oct 10 '24 05:10 lifeinchords

I think the method changes are doable somehow. But I think I would have to bundle Tweakpane to keep the plugin loadable like people are used to, and that might be a little worse for your situation.

samme avatar Oct 14 '24 15:10 samme