docker-gitlab icon indicating copy to clipboard operation
docker-gitlab copied to clipboard

Doesn't pickup LFS settings

Open ibaranov-t1a opened this issue 3 years ago • 2 comments

Hi all!

After adding the following options to the docker-compose.yml and doing 'docker-compose up' LFS doesn't seem to use S3 - GITLAB_LFS_ENABLED=TRUE - GITLAB_LFS_OBJECT_STORE_ENABLED=TRUE - GITLAB_LFS_OBJECT_STORE_REMOTE_DIRECTORY=**** - GITLAB_LFS_OBJECT_STORE_CONNECTION_PROVIDER=AWS - GITLAB_LFS_OBJECT_STORE_CONNECTION_AWS_ACCESS_KEY_ID=**** - GITLAB_LFS_OBJECT_STORE_CONNECTION_AWS_SECRET_ACCESS_KEY=**** - GITLAB_LFS_OBJECT_STORE_CONNECTION_AWS_REGION=us-east-1 - GITLAB_LFS_OBJECT_STORE_BACKGROUND_UPLOAD=false - GITLAB_LFS_OBJECT_STORE_DIRECT_UPLOAD=true

Also when I ssh into the gitlab container and check the /home/git/gitlab/config/gitlab.yml it doesn't seem to contain any of the LFS settings. Am I missing something?

ibaranov-t1a avatar Aug 04 '22 07:08 ibaranov-t1a

Could you try with true(lowercase) instead of TRUE(uppercase) ?
The value is compared as string (case sensitive), so the condition [[ TRUE == true ]] is false. And we update gitlab.yml only if ***_ENABLED is true, sometimes remove these unused (disabled) configurations. That's why your gitlab.yml does not contains GITLAB_LFS_* related settings.

kkimurak avatar Aug 04 '22 09:08 kkimurak

Thank you! It did work, however it doesn't want to load to S3 for some reasons (we don't use Minio). I'm researching logs, but I guess it's already not related to this issue so I'll close that one, thank you for your help!

ibaranov-t1a avatar Aug 04 '22 12:08 ibaranov-t1a