Sam Eiderman

Results 25 comments of Sam Eiderman

Yea > To be honest I'm also not so sure about if it's okay to document that an API call does not return content, when in practice it does, this...

> Hi @galihputera > > Sorry for the slow response. This looks good! Thank you! > > Have you tested this against Envoy or something like that? I don't have...

https://go-review.googlesource.com/c/protobuf/+/521215

Bump, I think this can count as a bug fix

Same for us. Removing `this.databaseInitialize(this.db)` solved this for us. Shouldn't `callback: this.database.Initialize` in `Db.create` be the caller? edit: I now see that `./db.ts` ignores the callback being passed in case...

Actually I'm pretty sure that we additionally need to update `same`s as well: ``` if refresh && ((m.Op == deploy.OpUpdate && m.DetailedDiff != nil) || m.Op == deploy.OpDelete || m.Op...

@lunaris thanks Adding my slack message for more context: https://pulumi-community.slack.com/archives/C84L4E3N1/p1722512361281309

Thanks, still I'm not sure about this PR as a contributor It does fix a bug, and is a good step forward, but it seems that the entire `--json` flow...

> Running tests to verify, but this could have some implications to our various testing methods. It looks like this upgrades us from a version that is ~2 years old....