Alexander Makarov comments

Results 1762 comments of


                                            Alexander Makarov

Islands support?

Islands could not be turned off for a single theme so, I guess, that would mean either adjusting defaults in this theme or doing another theme.

Perf: Inline getRootValue in getValue for simple array access

Need to compare results one more time.

Modules

See https://github.com/yiisoft/yii2/discussions/20493 as well. Could be done either as part of the guide or as a cookbook article.

refactor middleware authentication failure handler

@olegbaturin thanks for the pull request. Discussion with the code in front of you is way more productive.

`AbstractActiveRecord::newValues()` incorrectly marks DateTimeInterface attribute as changed

@darealfive do you have some time for a pull request?

`AbstractActiveRecord::newValues()` incorrectly marks DateTimeInterface attribute as changed

Sounds like the check should depend on the database type, i.e., if the timezone isn't stored in any way, then compare if that's the same moment in time. If the...

Feature Request: Intercept and save emails to files for local development

Yeah. Should generate proper `eml` files according to RFC 822.

Debug Toolbar memory exhaustion

Still, the idea of streaming debug data directly to files instead of accumulating/serializing it first sounds interesting.

Fixed `Message::parse()` regex to handle both multiple placeholders and deeply nested ones

I think there's no need for recursion. From [PSR-3](https://www.php-fig.org/psr/psr-3/): > Placeholder names MUST correspond to keys in the context array. > > Placeholder names MUST be delimited with a single...