phpGSB icon indicating copy to clipboard operation
phpGSB copied to clipboard
verified publisher icon samcleaver

Rewritten version to optimize requests and use of PHP5 OOP

Open smeinecke opened this issue 11 years ago • 2 comments

smeinecke avatar Jul 13 '14 21:07 smeinecke

@smeinecke Great looking work, obviously there's a huge amount of changes so will try and find some time this week to review. I had started a rewrite on the dev branch (https://github.com/samcleaver/phpGSB/tree/development/lib) that decoupled the storage side of the system (and added support for Yandex lists) but I still haven't gotten around to the lookup side of things.

Also just a heads up, V3 of the Google Safe Browsing API is now live also. (V2 is deprecated).

samcleaver avatar Jul 14 '14 19:07 samcleaver

Oh, I didn't see that you already rewritten the whole thing :+1: I added yandex support today too :) 2ce4f50eaabb9ff7e6cea7ed0b2b62941f2c531e

You dev branch looks much better than the old version - I will take a look into this next weekend. It's probably much better to complete that part (and move it to v3). As far as I read into the Changelog of v3 there are not that much changes.

I don't know if yandex also update to v3 like google.

smeinecke avatar Jul 14 '14 20:07 smeinecke