lo icon indicating copy to clipboard operation
lo copied to clipboard

Keys: accept multiple maps (vaargs)

Open samber opened this issue 1 year ago • 7 comments

From

lo.Keys[K comparable, V any](in map[K]V) []K

to

lo.Keys[K comparable, V any](in ...map[K]V) []K

In case of collision, deduplicate keys?

samber avatar May 13 '24 21:05 samber

Hey @samber I want to add a PR to resolve this issue. Can I get access to adding a PR for this issue ??

Also, I can see the Test of Keys is incorrect as it sorts the keys before asserting them, but there is no sort in the Keys function. I will also fix them.

shivamrazorpay avatar Jul 18 '24 12:07 shivamrazorpay

@ccoVeille I want to be a contributor. Can you help me to get access? I can fix this issue and some other open issues. Thank you. 😊

shivamrazorpay avatar Jul 19 '24 12:07 shivamrazorpay

I don't have much access than you do I think. I'm just a compulsive code reviewer. That's why you see me active.

You just have to fork the repository, push a branch on it, then open a PR mentioning the issue you want to fix.

I can review a PR if you open one.

ccoVeille avatar Jul 19 '24 13:07 ccoVeille

@ccoVeille by seeing your code reviews, I was amazed at how much good you are doing. I would love to chat with you one day. Can you also review my PR? Thank you.

shivamrazorpay avatar Jul 19 '24 19:07 shivamrazorpay

you are nice, thanks.

You can join the slack workspace of the gophers. You will find the link on my GitHub profile. So we can talk there

Edit: here is the link https://gophers.slack.com/team/U03FE6TMKPX

ccoVeille avatar Jul 19 '24 19:07 ccoVeille

Hello @ccoVeille how do I join the gophers slack channel?

dagenius007 avatar Jul 22 '24 20:07 dagenius007

Click on the link I provided, create an account if needed, install slack if needed.

If it doesn't work, try with this link

https://join.slack.com/t/gophers/shared_invite/zt-2lmem2ic2-EfbtKK9FGlBHHgeEu0an7Q

The link is valid for 4 days

cc @dagenius007

ccoVeille avatar Jul 22 '24 23:07 ccoVeille