[BUG] Traceback from _send_req_sync

[dwoz]

Feb 19 19:41:02 :     run_func(minion_instance, opts, data)

Feb 19 19:41:02 :   File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/minion.py", line 1923, in run_func

Feb 19 19:41:02 :     return Minion._thread_return(minion_instance, opts, data)

Feb 19 19:41:02 :   File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/minion.py", line 2159, in _thread_return

Feb 19 19:41:02 :     minion_instance._return_pub(ret)

Feb 19 19:41:02 :   File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/minion.py", line 2387, in _return_pub

Feb 19 19:41:02 :     ret_val = self._send_req_sync(load, timeout=timeout)

Feb 19 19:41:02 :   File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/minion.py", line 1649, in _send_req_sync

Feb 19 19:41:02 :     return ret["ret"]

Feb 19 19:41:02 : TypeError: 'NoneType' object is not subscriptable

Introduced by: #67096 Related to: #66562

[vkotarov]

@dwoz Things are not getting better after the commits in PR 67886, it's just a different error that the minion dies with:

2025-03-21 08:14:32,794 [salt.utils.process:999 ][ERROR   ][25580] An un-handled exception from the multiprocessing process 'ProcessPayload(jid=20250321081201012863)' was caught:
Traceback (most recent call last):
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/process.py", line 994, in wrapped_run_func
    return run_func()
  File "/opt/saltstack/salt/lib/python3.10/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/minion.py", line 1927, in _target
    run_func(minion_instance, opts, data)
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/minion.py", line 1921, in run_func
    return Minion._thread_return(minion_instance, opts, data)
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/minion.py", line 2157, in _thread_return
    minion_instance._return_pub(ret)
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/minion.py", line 2385, in _return_pub
    ret_val = self._send_req_sync(load, timeout=timeout)
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/minion.py", line 1650, in _send_req_sync
    raise TimeoutError("Request timed out")
TimeoutError: Request timed out

[vkotarov]

Changed

raise TimeoutError("Request timed out")

to

raise SaltReqTimeoutError("Request timed out")

hoping that it's handled better in the minion code but eventually no change:

2025-03-21 09:46:20,684 [salt.minion      :2295][INFO    ][124651] Returning information for job: 20250321094005749743
2025-03-21 09:47:20,748 [salt.utils.process:999 ][ERROR   ][124651] An un-handled exception from the multiprocessing process 'ProcessPayload(jid=20250321094005749743)' was caught:
Traceback (most recent call last):
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/process.py", line 994, in wrapped_run_func
    return run_func()
  File "/opt/saltstack/salt/lib/python3.10/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/minion.py", line 1927, in _target
    run_func(minion_instance, opts, data)
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/minion.py", line 1921, in run_func
    return Minion._thread_return(minion_instance, opts, data)
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/minion.py", line 2157, in _thread_return
    minion_instance._return_pub(ret)
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/minion.py", line 2385, in _return_pub
    ret_val = self._send_req_sync(load, timeout=timeout)
  File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/minion.py", line 1650, in _send_req_sync
    raise SaltReqTimeoutError("Request timed out")
TimeoutError: Request timed out