salt icon indicating copy to clipboard operation
salt copied to clipboard

#62626 moved bin_env to example

Open muckitymuck opened this issue 3 years ago • 2 comments

What does this PR do?

Moves the bin_env down to its example in file salt.7

What issues does this PR fix or reference?

Fixes: #62626

Merge requirements satisfied?

  • [ X] Docs
  • [ ] Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
  • [ ] Tests written/updated

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

muckitymuck avatar Sep 20 '22 17:09 muckitymuck

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey. Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

welcome[bot] avatar Sep 20 '22 17:09 welcome[bot]

This does not fix the problem. This is only moving it in the man page. This needs to be fixed in https://github.com/saltstack/salt/blob/master/salt/states/pip_state.py#L568-L618 which will also end up fixing the man page.

whytewolf avatar Sep 20 '22 18:09 whytewolf

@muckitymuck This is not the fix for that ticket. This isn't even going to work as the man page is generated. I pointed out what needs to change in the above comment. If you want to make that change i would be happy to review this. but if not i will go ahead and close this PR without merging.

whytewolf avatar Sep 23 '22 23:09 whytewolf

@muckitymuck did you see @whytewolf 's comments?

Ch3LL avatar Oct 04 '22 20:10 Ch3LL

Sorry, all. I am trying to set up my sphinx but no luck. I think someone else will have to finish it.

muckitymuck avatar Oct 04 '22 20:10 muckitymuck

@muckitymuck No problem. I'll go ahead and close his PR.

whytewolf avatar Oct 05 '22 16:10 whytewolf