saltstack
Recognize OSMC as Debian-based
What does this PR do?
This changes recognizes OSMC as Debian based.
What issues does this PR fix or reference?
Fixes: #62198
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
- [ ] Docs
- [ ] Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
- [ ] Tests written/updated
Commits signed with GPG?
No, sorry
Should I pull from upstream master and rebase on top? Or add a test somewhere? The change is trivial, please let me know if anything is needed.
@dwoz Is there anything I can do to make the review easier? The failing check seems unrelated.
@nkuttler Thanks for the PR. If you check salt/tests/pytests/unit/grains/test_core.py and look for the test test_mendel_os_grains, duplicating that test and swapping in the right bits for OSMC should be a sufficient test to get this merged in.
@nkuttler Looks like a failure in the test. Looking at the new test and the result, it looks like the expected versions should all be 2020 based on the _os_release_map values. Also could you please add a changelog to the changelog directory? Filename should be 62198.fixed based on the issue you're fixing and should contain a short line of what you're fixing. Thanks!
@garethgreenaway Thanks a lot for looking into this! I think the one check that fails was not related to my latest commit? But the log is a little overwhelming tbh.
@nkuttler Nope. not related. Looks like a timeout of sorts. I restarted the test.