Add metadata server host
What does this PR do?
add minion configs parameter metadata_server_host for /salt/metadata.py to handle the cloud providers which not using 169.254.169.254 as metadata server
What issues does this PR fix or reference?
Previous Behavior
when metadata_server_grains=true the /salt/metadata.py functions will fetch metadata from 169.254.169.254 without any other choices
New Behavior
Allow clients to specify a custom metadata server host for the grains feature of metadata_server_grains=true when metadata_server_grains=true the /salt/metadata.py functions will fetch metadata from the host set with minion config parameter metadata_server_host first, if metadata_server_host is not set the function will fetch from 169.254.169.254 by default.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
- [ ] Docs
- [ ] Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
- [ ] Tests written/updated
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.
Hi! I'm your friendly PR bot!
You might be wondering what I'm doing commenting here on your PR.
Yes, as a matter of fact, I am...
I'm just here to help us improve the documentation. I can't respond to questions or anything, but what I can do, I do well!
Okay... so what do you do?
I detect modules that are missing docstrings or "CLI Example" on existing docstrings! When I was created we had a lot of these. The documentation for these modules need some love and attention to make Salt better for our users.
So what does that have to do with my PR?
I noticed that in this PR there are some files changed that have some of these issues. So I'm leaving this comment to let you know your options.
Okay, what are they?
Well, my favorite, is that since you were making changes here I'm hoping that you would be the most familiar with this module and be able to add some other examples or fix any of the reported issues.
If I can, then what?
Well, you can either add them to this PR or add them to another PR. Either way is fine!
Well... what if I can't, or don't want to?
That's also fine! We appreciate all contributions to the Salt Project. If you can't add those other examples, either because you're too busy, or unfamiliar, or you just aren't interested, we still appreciate the contributions that you've made already.
Whatever approach you decide to take, just drop a comment here letting us know!
Detected Issues (click me)
Check Known Missing Docstrings...........................................Failed - hook id: invoke - duration: 1.48s - exit code: 1/home/runner/.cache/pre-commit/repo_6hm1ct_/py_env-python3/lib/python3.9/site-packages/_distutils_hack/init.py:30: UserWarning: Setuptools is replacing distutils. warnings.warn("Setuptools is replacing distutils.") The function 'metadata' on 'salt/grains/metadata.py' does not have a docstring Found 1 errors
Thanks again!
@superzc-github do you have time to loop back to this PR for the feedback and adding test coverage?
bump @superzc-github did you see my feedback?
Closing due to inactivity. Please let me know if you want me to re-open the PR or you can submit a new PR against the master branch with the test coverage for this change.