salt-ext-modules-vmware icon indicating copy to clipboard operation
salt-ext-modules-vmware copied to clipboard

Adds allocated resources to vm info

Open abhi1693 opened this issue 3 years ago • 2 comments

Closes: #288

abhi1693 avatar Oct 20 '22 13:10 abhi1693

@joechainz Hi Joe, is it possible to help merge this PR? I'm not good with pytest and currently dont have an environment to write integration tests.

abhi1693 avatar Mar 18 '23 17:03 abhi1693

@abhi1693 All code requires tests before it should be committed, the lack of tests been written for Salt code created many problems (and this was even with eyes on it from core team members), hence from Salt version 2019.2.0 on, all code required tests be written to exercise the changes.

You should look at this as a learning opportunity for PyTest since it is heavily used now within the industry and it is required for all new code in Salt. There are a number of how-to videos on PyTest with Salt on Twitch, search for Wayne Werner who gave the talks

dmurphy18 avatar Mar 24 '23 16:03 dmurphy18