pepper icon indicating copy to clipboard operation
pepper copied to clipboard

Adds full_return support in libpepper.

Open RyanFrantz opened this issue 7 years ago • 5 comments

  • This allows folks using this as a library to get the same behavior as CLI (cli.run() sets full_return=True), if they so choose.

RyanFrantz avatar Oct 19 '18 22:10 RyanFrantz

Codecov Report

Merging #175 into develop will decrease coverage by 0.72%. The diff coverage is 12.5%.

@@             Coverage Diff             @@
##           develop     #175      +/-   ##
===========================================
- Coverage    72.39%   71.66%   -0.73%     
===========================================
  Files            5        5              
  Lines          594      600       +6     
  Branches       126      129       +3     
===========================================
  Hits           430      430              
- Misses         137      142       +5     
- Partials        27       28       +1

codecov[bot] avatar Oct 22 '18 18:10 codecov[bot]

I am working on fixing the tests in travis, would you please add some tests for the extra branchs you added for full_return?

gtmanfred avatar Dec 01 '18 00:12 gtmanfred

Coming back around to this. I'll poke this a bit next week, including syncing with upstream master and writing tests.

RyanFrantz avatar Mar 01 '19 21:03 RyanFrantz

Awesome, thanks!

gtmanfred avatar Mar 01 '19 21:03 gtmanfred

Howdy! :wave:

Apologies for the long delay on this integrating this code. We certainly appreciate your effort!

Pepper is getting some renewed focus and love, and we're checking in to see if you'd like to update this against the latest version of the base branch and ensure that all merge conditions are met.

If the items addressed by this contribution have already been fixed/added, are no longer an issue, or you no longer have a desire to work on this... please let us know and/or close out this PR.

If we don't hear from you within 7 days, we'll assume the code has been abandoned and close it out. If you'd like to revisit this in the future, you can always open a new PR.

Thank you, and we hope to see you active in the Salt ecosystem in the future!

nicholasmhughes avatar Apr 20 '23 19:04 nicholasmhughes