consul-formula icon indicating copy to clipboard operation
consul-formula copied to clipboard
verified publisher icon saltstack-formulas

consul*/install.sls refactoring

Open nledez opened this issue 7 years ago • 10 comments

consul*/install.sls refactoring. Come from https://github.com/saltstack-formulas/vault-formula.git

  • use /opt (to remove consul-* versions in autocomplete)
  • checksum check includes GPG one

nledez avatar Nov 04 '18 15:11 nledez

Work on Travis issue.

nledez avatar Nov 04 '18 15:11 nledez

Ready to merge.

I remove gpg package dependency (remove gpg uninstall package managers too on Ubuntu/Centos).

nledez avatar Nov 04 '18 17:11 nledez

Hey @nledez, nice enhancement here. I've added a couple comments regarding areas where you could use some salt modules instead of calling commands directly and places where you could do a cleanup.

jeduardo avatar Dec 22 '18 12:12 jeduardo

@jeduardo are you happy with merging this?

aboe76 avatar Dec 22 '18 13:12 aboe76

Hi @jeduardo, I'm happy if I can improve this formulas :) But I didn't see any comments in PR :/

nledez avatar Dec 26 '18 22:12 nledez

@nledez ah of course, I have forgotten to click on "submit review" after creating the review. You should see comments now I hope.

jeduardo avatar Dec 27 '18 10:12 jeduardo

@aboe76 I'd like @nledez to have a look at the suggestions that are now visible before merging this.

jeduardo avatar Dec 27 '18 10:12 jeduardo

OK I miss GH notifies. I work on it ASAP.

nledez avatar Jan 02 '19 12:01 nledez

@nledez do you want to refactor the proposed changes from @jeduardo ?

aboe76 avatar Feb 15 '19 21:02 aboe76

@nledez ping

aboe76 avatar Mar 16 '19 18:03 aboe76