saloon icon indicating copy to clipboard operation
saloon copied to clipboard

Renamed $response to $responseClass for better clarity

Open mstfblci opened this issue 1 year ago • 3 comments

Reflects improved naming for better code readability and maintainability

mstfblci avatar Sep 12 '24 14:09 mstfblci

If I use withResponse it conflicts with the $response variable in the hasCustomResponses trait so it is important to replace it with $responseClass.

mstfblci avatar Sep 17 '24 11:09 mstfblci

@Sammyjo20 I also changed the name of the trait for better clarity.

mstfblci avatar Sep 26 '24 13:09 mstfblci

This is definitely a breaking change FYI for anyone implementing custom response classes: https://docs.saloon.dev/the-basics/responses

Neither for or against it but as long as it's known it's breaking.

Cbrad24 avatar Oct 09 '24 05:10 Cbrad24

This is considered a breaking change which I wouldn't be willing to allow until v4 is released.

Sammyjo20 avatar Dec 03 '24 00:12 Sammyjo20