grpc-java-contrib icon indicating copy to clipboard operation
grpc-java-contrib copied to clipboard

Bump grpc + protoc versions

Open ayoukhananov opened this issue 3 years ago • 1 comments

I've experienced an issue trying to use the 3.19.4 version of protoc and grpc-java to being able to compile with a Custom Generator .

Using: com.google.protobuf.protoc = 3.19.4 protoc-gen-grpc-java.plugin = 1.45.1 (1.37.0 has an internal dependency on protobuf-java that does not contain com.google.protobuf.GeneratedMessageV3.isStringEmpty)

The issue : The problem is that the latest protoc generates code that depends on function (com.google.protobuf.GeneratedMessageV3.isStringEmpty) that are available from 3.17.3+.

The current issue: Since jprotoc using shade plugin to create the jar it brings protoc and protobuf code inside the jar

It also can solve compatibility with M1 mac : https://github.com/grpc/grpc-java/issues/8724

ayoukhananov avatar Apr 06 '22 10:04 ayoukhananov

Thanks for the contribution! Before we can merge this, we need @ayoukhananov to sign the Salesforce.com Contributor License Agreement.

salesforce-cla[bot] avatar Apr 06 '22 10:04 salesforce-cla[bot]

Close/reopen to re-run CI

rmichela avatar Dec 16 '22 17:12 rmichela

Superseded by #192

rmichela avatar Dec 16 '22 17:12 rmichela