developer.sailpoint.com icon indicating copy to clipboard operation
developer.sailpoint.com copied to clipboard

[Bug] Nullable field is not nulable and is required - 'Rejects an access request approval.' (reject-access-request)

Open stephen-holinaty-sp opened this issue 2 years ago • 2 comments

Describe the bug The "Comment" field is either not in fact nullable, or IS in fact required

To Reproduce Steps to reproduce the behavior:

  1. have an access request that you wish to close, such as anything from /v3/access-request-approvals/pending get the $[*].id from the above - the access request ID.

  2. make a POST call to /v3/access-request-approvals/{approvalId}/reject using the ID from step 1

  3. submit with NO body, receive error: Required field "comment" was missing or empty.

  4. submit with body {"comment":null} , receive error: Required field "comment" was missing or empty.

  5. submit with body {"comment":""}, receive error: Required field "comment" was missing or empty.

  6. submit with body {"comment":"."}, and receive a successful HTTP202 no content

Expected behavior A POST with no body should be accepted, assuming that there is no comment a POST with body: {} should be accepted, assuming there is no comment a POST with body {"comment":null} should be accepted, assuming there is no content (since its flagged as nullable)

OR

the documentation should be fixed to ADD "required" to the comment field, and REMOVE "nullable" from the comment field

Actual behavior field COMMENT appears to be required, and non-nullable

Operating System (please complete the following information): Postman

Browser (please complete the following information): Postman

stephen-holinaty-sp avatar Nov 10 '23 14:11 stephen-holinaty-sp

🎉 Thanks for opening your first issue here! Be sure to follow the issue template, and welcome to the community! 🙌

codey-bot[bot] avatar Nov 10 '23 14:11 codey-bot[bot]

this MIGHT apply to the Approve endpoint as well as the Reject.

stephen-holinaty-sp avatar Nov 10 '23 14:11 stephen-holinaty-sp