patchmanager icon indicating copy to clipboard operation
patchmanager copied to clipboard

[Bug] files paths in the patch not always correctly parsed

Open robang74 opened this issue 2 years ago • 4 comments

SailFish OS version: 4.5.0.9 Patchmanger Version: 3.2.9 Hardware: Xperia 10 II

BUG DESCRIPTION

Referring to this patch (untested code):

  • https://coderus.openrepos.net/pm2/project/zram-swap-resize-script

this is the output in the log when the patch is installed:

void PatchManagerObject::doRefreshPatchList() Collecting info for:  "zram-swap-resize-script"
void PatchManagerObject::doRefreshPatchList() Possible conflict in:  "/usr/bin/zram_swap_resize.sh"

and this the same when it is not installed:

void PatchManagerObject::doRefreshPatchList() Collecting info for:  "zram-swap-resize-script"
void PatchManagerObject::doRefreshPatchList() Possible conflict in:  "/zram_swap_resize.sh"

in the second case the patch files paths parsing is wrong, unless I created that file which does not exist by default.

STEPS TO REPRODUCE

  1. download from Web Catalog the patch above
  2. switch the Patch Manager to developer mode
  3. then enable and disable the patch
  4. check the Patch Manager log

ADDITIONAL INFORMATION

Proposed bug-fix

  • https://github.com/sailfishos-patches/patchmanager/commit/f247da61c2e2df06274b00d40ddc605b98740ade

Let me know and I will do a pull/merge request.

robang74 avatar Jul 02 '23 08:07 robang74

Please take care to fix the code issues reported by this person, but create your own changes. no commits authored by this person are allowed to be merged in this repo.

CODeRUS avatar Jul 21 '23 21:07 CODeRUS

@nephros @nephros @Olf0 fyi

CODeRUS avatar Jul 21 '23 21:07 CODeRUS

@b100dian was missed.

Olf0 avatar Jul 22 '23 21:07 Olf0

Please let us carry out this meta-discussion at the oldest bug report filed by robang74: #444

Every thing discussed there an the meta-level is sure applicable to the filed issues #445 and #446, too (plus any future ones by robang74).

Olf0 avatar Jul 22 '23 21:07 Olf0