safe-react icon indicating copy to clipboard operation
safe-react copied to clipboard

During scanning owner address it's possible to add the same owner twice( no error)

Open liliya-soroka opened this issue 3 years ago • 1 comments

Description

During scanning owner address it's possible to add the same owner twice( no error)

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Chain: Rinkeby
  • https://pr3661--safereact.review-safe.gnosisdev.com/app/welcome

Steps to reproduce

  1. Go to create safe flow
  2. enter name and go to the owner list
  3. add two field to add owner
  4. remove the first empty line and add one more
  5. scan qr code with address to add the address as an owner in the first empty line

Current result: The same address is added twice : with prefix and without prefix and there is no error message about duplication .The user can continue safe creation but it will fail

Expected result

Make sure that scanned address appears only in the proper field and the error appears if the same address is used twice

Screenshots

https://drive.google.com/file/d/1-jufoUc8u6VFpyygipnHug5fqVtdhNGe/view?usp=sharing

liliya-soroka avatar Mar 14 '22 14:03 liliya-soroka

Now the system detects that there is a duplicated address, so that's fixed, but we still have the issue of the 2 lines with the same address when no new line should be added in this scenario gif: 03-31-2022_x(4599)

francovenica avatar Mar 31 '22 04:03 francovenica