safe-react icon indicating copy to clipboard operation
safe-react copied to clipboard

Transaction queue doesn't show all txs for big queues

Open Fang- opened this issue 4 years ago • 1 comments

Description

The transactions queue only displays up to 20 transactions, even if there are more transactions in the queue.

Environment

  • Browser: Latest Firefox
  • Wallet: -
  • Safe: read-only, 0x5eB03d359E6815d6407771Ab69e80af5644104B9
  • Environment: mainnet

Steps to reproduce

  1. Propose many txs with sequential safe-nonces. (We used a delegate.)
  2. View the transaction queue.

Expected result

All the transactions show up in the list, and/or the transaction queue is paginated to let us view & interact with the whole queue.

Obtained result

Only transactions up to nonce n+20 show up. If there are multiple proposed transactions for a given nonce, these count towards the total of transactions displayed. (ie two proposals for nonce n mean the last nonce to show is n+19)

We know there is more in the queue because the safe-transaction.mainnet.gnosis.io/api/v1/safes/0xetc/transactions/ endpoint returns the whole list.

Fang- avatar Nov 18 '21 20:11 Fang-

We'll need to implement the same infinite scroll as the history. Or increase the page size. Consult with @gnosis/safe-services.

katspaugh avatar Dec 09 '21 14:12 katspaugh

To add more feedback, adding the infinite scroll to the "Queue" page would be great for visual debugging of the (currently hidden) txs.

For my use-case, it is definitely not a high prioirty, but just wanted to add a +1 here :)

shanefontaine avatar Aug 31 '22 01:08 shanefontaine

This has been fixed in the new repo: https://github.com/safe-global/web-core/

katspaugh avatar Aug 31 '22 05:08 katspaugh