safe-react icon indicating copy to clipboard operation
safe-react copied to clipboard

Fetch app manifest at the root

Open mmv08 opened this issue 4 years ago • 2 comments

What is this feature about? (1 sentence)

We had quite some requests to fetch the manifest.json file at the root, so if the app URL is company.io/app it would fetch it from company.io/manifest.json. This is the way manifest.json is expected to work:

served from the root (your website's top-level directory).

Why is it needed? What is the value? For whom do we build it?

Our current behavior is not the standard and it would make sense to tweak it while keeping backward compatibility

High-level overview of the feature

In the addition to current relative fetch, try to fetch manifest.json from the root

High-level motivation

Currently our manifest.json logic is not the same as the common manifest.json logic for web apps (or PWAs). Therefore we cannot take advantage of the existing manifest.json files in most apps without additional changes to it. By complying to the standard it will be possible to use existing apps as Safe apps without additional migration steps (at least in many cases).

mmv08 avatar Jun 07 '21 08:06 mmv08

This issue has a backend dependency as the client gateway would also have to adjust this

rmeissner avatar Jun 07 '21 08:06 rmeissner

I've opened an issue, just to close the information loop: https://github.com/gnosis/safe-client-gateway/issues/420

The spec would need to be refined to use exactly what the web app would expect.

jpalvarezl avatar Jun 07 '21 09:06 jpalvarezl