safe-react-apps icon indicating copy to clipboard operation
safe-react-apps copied to clipboard

chore(tx-builder-theme): Remove safe-react components and theme from the tx-builder application

Open clovisdasilvaneto opened this issue 1 year ago • 1 comments

Current we're using an outdated theme in the transaction builder application. In order to have the right theme introduced on it, we need to first adjust the internal theme structure which we use in our components, and since the https://github.com/5afe/safe-react-components repo is achieved me and @katspaugh decided to move the components to the tx-builder/components folder and change the internal theme structure that the components are using.

What it solves

Resolves #820

How this PR fixes it

It uses the moved safe-react-components in the tx-builder screens

How to test it

  • Open the safe wallet and add the tx-builder as a custom application, you should see the new theme colors as per figma design: https://www.figma.com/design/tQyUQeAwxJkRfFmJCLU3wC/Safe-Apps-Redesign?node-id=2908-10267&t=M4BdtdYTY2lkbM5F-1
Screenshot 2024-09-25 at 11 53 02

clovisdasilvaneto avatar Sep 25 '24 09:09 clovisdasilvaneto

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

github-actions[bot] avatar Sep 25 '24 09:09 github-actions[bot]

Question. I see in the designs that the form should be on the full width of the view port. Is this only for small viewports?

This is how I currently see it image

This is from the design: image

This is the only difference I see, so if the width of the form is not part of the changes then the ticket is good to go

francovenica avatar Oct 02 '24 15:10 francovenica

Hi @francovenica, yes the form width is not part of the change, however I think I can make it looks a bit better.

clovisdasilvaneto avatar Oct 02 '24 15:10 clovisdasilvaneto

Ok, the ticket how it is can be passed to "ready to merge". Let me know if you can try that change you suggested here or if you will create a new PR for it. Thanks

francovenica avatar Oct 04 '24 01:10 francovenica