safe-react-apps icon indicating copy to clipboard operation
safe-react-apps copied to clipboard

[Safe Apps] App Details

Open lukasschor opened this issue 5 years ago • 11 comments

Why do we need this?

As I user I want to be able to see who has developed a Safe App so that I can increase my trust in the Safe App or contact the developer in case there are any issues

What is this about?

See designs. Instead of the entire footer, we should only display the "i" icon in the bottom-right corner of the app. Clicking this icon would open the App Details modal.

image.png

image.png

In this modal, we should display information from the Safe App manifest

For "whitelisted" apps we should display:

  • Description
  • Developer
  • Website

For "non-whitelisted" apps (i.e. custom apps) we should display only Description as else the Developer/Website information could be spoofed.

lukasschor avatar Feb 04 '20 09:02 lukasschor

@lukasschor Is the description composed only by Title and Description? When the app is not provided by Gnosis, from where should we get that information?

nicosampler avatar Feb 06 '20 12:02 nicosampler

Might make sense to have the (i) in the bottom-left corner so that it does not interfere with the Intercom chat bubble.

lukasschor avatar Sep 21 '20 21:09 lukasschor

@posthnikova

tschubotz avatar Sep 24 '20 12:09 tschubotz

The App details are also planned to be visible from the Safe Apps overview page gnosis/safe-react#1294. I think this might remove the need for also displaying it in the individual app views.

lukasschor avatar Sep 27 '20 11:09 lukasschor

The App details are also planned to be visible from the Safe Apps overview page gnosis/safe-react#1294. I think this might remove the need for also displaying it in the individual app views.

There will be some transitional period when we won't have apps overview page. So for the old layout we need an info button on individual app screen. I propose we have a 'whitelisted' icon for apps which are whitelisted.

image

For the new layout the info button will be on apps overview page.

image

posthnikova avatar Sep 28 '20 12:09 posthnikova

I propose we have a 'whitelisted' icon for apps which are whitelisted.

What does "whitelisted" mean? Whitelisted as in "they appear in the interface since we added them?"

tschubotz avatar Sep 28 '20 13:09 tschubotz

@tschubotz I mean added by us.

posthnikova avatar Sep 28 '20 13:09 posthnikova

@tschubotz I mean added by us.

Hmm. When adding a checkmark, we would need to also communicate what it means. In our terms, we follow the argumentation line "Safe apps are made by the respective developer, we did not audit them and don't vouch for "no bugs".

Hence I think we should not have this "checkmark" since we can't be liable for this.

tschubotz avatar Sep 28 '20 14:09 tschubotz

So the difference of whitelisted apps from custom apps in the UI would be that whitelisted apps have 'Developer' and 'Website'. Custom apps would only have text description.

image

posthnikova avatar Sep 29 '20 13:09 posthnikova

Question: do custom apps have description? Where does it come from?

image

When adding custom app, there is no field to enter desription.

image

posthnikova avatar Oct 05 '20 10:10 posthnikova

Question: do custom apps have description? Where does it come from?

@posthnikova The description is defined by the Safe app developer via the manifest.json. Example can be found there: https://ipfs.io/ipfs/QmTgnb1J9FDR9gimptzvaEiNa25s92iQy37GyqYfwZw8Aj/manifest.json

tschubotz avatar Oct 05 '20 11:10 tschubotz