motion icon indicating copy to clipboard operation
motion copied to clipboard
verified publisher icon sackmotion

no longer builds for any architecture except x86

Open infinity0 opened this issue 11 years ago • 4 comments

Commit 8de231568b7c43c7672f9e508c308d9bc715d120 broke the build for all non-x86 architectures. The offending code is this:

#ifndef __SSE_MATH__
    __asm__ __volatile__ ( "emms");
#endif

Changing it to

#ifdef __MMX__
    __asm__ __volatile__ ( "emms");
#endif

(similar to how things are done in alg.c) restores the build for all platforms.

I have added this to pull request #16.

infinity0 avatar Mar 14 '14 00:03 infinity0

There is already pull request for this: https://github.com/sackmotion/motion/issues/7

tosiara avatar Mar 14 '14 06:03 tosiara

My patch is shorter and consistent with the existing code in alg.c which uses __MMX__, and more "to the point". We want to check for MMX, not the lack of anything else, "not not MMX".

infinity0 avatar Mar 14 '14 12:03 infinity0

My mentioned pull request has been commited int mainstream: https://github.com/sackmotion/motion/commit/ad7e243fcaee500f67297305d9235556fb4270b9

tosiara avatar Mar 24 '14 16:03 tosiara

Added some more commits (42bacdc5, 20fb8312) to build for Debian GNU/kFreeBSD.

infinity0 avatar Jul 30 '15 11:07 infinity0