http icon indicating copy to clipboard operation
http copied to clipboard
verified publisher icon sabre-io

Test enhancement

Open peter279k opened this issue 7 years ago • 2 comments

Changed log

  • add more tests.

peter279k avatar Mar 16 '18 16:03 peter279k

Codecov Report

Merging #98 into master will increase coverage by 0.76%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #98      +/-   ##
============================================
+ Coverage        89%   89.76%   +0.76%     
  Complexity      244      244              
============================================
  Files            15       15              
  Lines           782      782              
============================================
+ Hits            696      702       +6     
+ Misses           86       80       -6
Impacted Files Coverage Δ Complexity Δ
lib/functions.php 98.46% <ø> (+1.53%) 0 <0> (ø) :arrow_down:
lib/Sapi.php 98.92% <0%> (+2.15%) 34% <0%> (ø) :arrow_down:
lib/Auth/AWS.php 89.18% <0%> (+2.7%) 23% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 087ad4b...0951e9a. Read the comment docs.

codecov-io avatar Mar 16 '18 16:03 codecov-io

A rebased version is in PR #176

phil-davis avatar Nov 02 '21 16:11 phil-davis

The test changes have been merged in #176 - thanks

I will make a separate commit and PR to fixup the code change in lib/functions.php

phil-davis avatar Aug 26 '22 05:08 phil-davis