gettext-tiny icon indicating copy to clipboard operation
gettext-tiny copied to clipboard

Error building git with gui support.

Open CamilleScholtz opened this issue 8 years ago • 9 comments

Running gettext-tiny 0.2.0 on CRUX, I'm 80% sure this is a gettext-tiny caused error:

    SUBDIR git-gui
GITGUI_VERSION = 0.21.GITGUI
    * new locations or Tcl/Tk interpreter
    MSGFMT po/pt_pt.msg     MSGFMT    po/ru.msg make[1]: *** [Makefile:252: po/pt_pt.msg] Error 127
    MSGFMT    po/ja.msg make[1]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:252: po/ru.msg] Error 127
make[1]: *** [Makefile:252: po/ja.msg] Error 127
make: *** [Makefile:1797: all] Error 2
=======> ERROR: Building '/usr/src/pkg/pkg/git#2.14.2-1.pkg.tar.gz' failed

CamilleScholtz avatar Oct 23 '17 20:10 CamilleScholtz

could you please try latest git ? there have been a number of fixes since 0.2.0

rofl0r avatar Oct 23 '17 21:10 rofl0r

Nope, sadly the same error.

CamilleScholtz avatar Oct 23 '17 22:10 CamilleScholtz

Error 127 sounds like a segfault... would you be able to catch a backtrace ?

rofl0r avatar Oct 23 '17 22:10 rofl0r

@onodera-punpun cant reproduce, please provide more information, like configure options, set -x, or make V=1

GITGUI_VERSION = 0.21.GITGUI-dirty
    * new locations or Tcl/Tk interpreter
    MSGFMT po/zh_cn.msg     MSGFMT    po/ru.msg     MSGFMT    po/el.msg     MSGFMT po/pt_br.msg     MSGFMT    po/it.msg 366 translated, 8 fuzzy, 17 untranslated.
    MSGFMT    po/bg.msg 520 translated.
    MSGFMT    po/fr.msg 520 translated.
    MSGFMT    po/nb.msg 381 translated, 10 fuzzy.
    MSGFMT    po/hu.msg 519 translated, 1 untranslated.
    MSGFMT    po/sv.msg 474 translated, 39 untranslated.
    MSGFMT    po/vi.msg 520 translated.
    MSGFMT    po/ja.msg 547 translated.
    MSGFMT po/pt_pt.msg 514 translated.
    MSGFMT    po/de.msg 565 translated.

xhebox avatar Oct 24 '17 15:10 xhebox

No configure options, no CFLAGS, etc:

~/tmp/git-2.14.2 make V=1
make -C git-gui  gitexecdir='/home/onodera/libexec/git-core' all
make[1]: Entering directory '/home/onodera/tmp/git-2.14.2/git-gui'
tclsh po/po2msg.sh --statistics --tcl -l de -d po/ po/de.po
make[1]: tclsh: Command not found
make[1]: *** [Makefile:252: po/de.msg] Error 127
make[1]: Leaving directory '/home/onodera/tmp/git-2.14.2/git-gui'
make: *** [Makefile:1797: all] Error 2

I've now confirmed that it actually does build with normal gettext which doesn't provide tclsh.


gettext-tiny build instructions used, it might be I am doing something wrong here? https://github.com/6c37/crux-ports-dropin/blob/3.3/gettext-tiny/Pkgfile

CamilleScholtz avatar Oct 24 '17 16:10 CamilleScholtz

@rofl0r @onodera-punpun OK, so here's the reason:

	MSGFMT ?= msgfmt
	ifneq ($(shell $(MSGFMT) --tcl -l C -d . /dev/null 2>/dev/null; echo $$?),0)
		MSGFMT := $(TCL_PATH) po/po2msg.sh
	endif

-l C is not handled correctly, and -d . will cause an abort. i think tiny should work even if these two features are not supported. and we may not implement them since those two options are not included as one of our goals. we still need a discussion on 'abort or ignore to pass?' .

as a temporary solution, install tclsh, or manually edit MAKEFILE. anyway, thanks for your reports :). i am going to sleep.

xhebox avatar Oct 24 '17 17:10 xhebox

@onodera-punpun i committed @xhebox's fix to master, would you be so kind as to check if your issue is fixed ?

rofl0r avatar Nov 07 '17 15:11 rofl0r

@rofl0r @xhebox Nope, sadly it doesn't seem to work for me.

CamilleScholtz avatar Nov 08 '17 19:11 CamilleScholtz

@onodera-punpun really sorry, try new commits again please :) i should have tested but my scripts installed tcl automatically before my test, which means i did not test without tclsh actually.

EDIT: and if convenient, please try autopoint before autoconf or just autoreconf -i to solve the problem in another issue, it's not a bug of programs.

xhebox avatar Nov 09 '17 04:11 xhebox

every chekc this post : http://juniway.blogspot.com/2015/12/build-git-from-source-on-ubuntu.html

  1. sudo apt-get install tcl-dev
  2. sudo apt-get install gettext
  3. sudo apt-get install libcurl4-openssl-dev

this works for me

feizhengyang avatar Jul 07 '23 13:07 feizhengyang

let's pretend this issue is fixed, since we didnt hear anything. @feizhengyang: nice trolling.

rofl0r avatar Jul 07 '23 16:07 rofl0r