Lags, probably during autosave

[Iey4iej3]

Describe the bug

It seems that there are significant lags probably during autosave. A similar issue was solved months ago, and the current one appears only in very recent versions.

To reproduce

1. Keep writing;
2. Encounter the lag probably when an autosave is performed.

Expected behavior

No perceivable lag.

Saber version

v0.20.3

Device

• Device: Samsung Tab S6 Lite
• OS: Android 13

Anything else?

No response

[QubaB]

1. Are there images in note?
2. Big amount of images?
3. Large images?
4. Or only hand writing?
5. Do you synchronize to nextcloud?

[Iey4iej3]

Only handwriting, and ~ 25 pages (@QubaB Sorry, previously I mistakenly opened another note and the number of pages is now corrected, although I have not tested systematically whether this could happen for documents with fewer pages). Synchronize to the official server.

[QubaB]

I observe lag during autosave (created testing note with 10 pages of handwriting).

I do not know if this can be avoided. I do not understand source code enough to see if saving is done in another thread (on background) or whole Saber runs in only one thread and then saving should produce lags.

[QubaB]

I think that lag is caused by creation of note thumbnail during each Save. When I turned off creation of thumbnails (in developer version), lagging was not almost noticable.

I will try to create fix, which will implement that during autosave is not created thumbnail.

[Iey4iej3]

I do not understand source code enough to see if saving is done in another thread (on background) or whole Saber runs in only one thread and then saving should produce lags.

It is done in background: https://github.com/saber-notes/saber/issues/179#issuecomment-1615265288

[Iey4iej3]

I think that lag is caused by creation of note thumbnail during each Save.

I guess that thumbernails should be produced when the notes are closed. Doing it during autosaves does not seem to be meaningful, indeed.

[Polux49]

I experienced a lot of lags too, with Appimage v0.21.4, even on short notes (3 pages, but with a few emoji images).

[QubaB]

This feature is not implemented yet. See pull request #1136

[danielwmoore]

I was also experiencing lags during autosave. I have disabled autosave and just make sure I save before I exit. Dramatically improved the usage of the app.

[6b6279]

I haven't done an exhaustive search, but 0.21.0 seems to not have this issue. I reckon it's caused by a95f44bb2d275d57cabb42f3779bd13019cbf725, which makes it a duplicate of #1189. Autosaving causes roughly the same amount of lag as simply saving to exit.