developerFolio icon indicating copy to clipboard operation
developerFolio copied to clipboard

Add Custom Images and text for Github Profile Card

Open naveen521kk opened this issue 5 years ago • 19 comments

Summary

~~Using Gravatar API we can get the profile of the user with their email address converted to MD5 hash very easily. This can be an alternative for users who don't have Github Account, also it needs no authorisation.~~

Update: Read discussion below to further understand the issue.

What's new?

~~Add an option for Gravatar Profile of users~~ Update: Add an option for users to set custom images and info for the GitHub Profile/Contact Card

naveen521kk avatar Jul 15 '20 11:07 naveen521kk

Do people still use Gravatar? It was big in like 2010 on forums I remember, but now most websites just use google OAuth to get all the usual data including profile pictures. Also the GH profile card is dependent on user data from Github to fill the blanks, adding Gravatar would require manual setup which I think should be added regardless of Gravatar so everyone can use the new contact section and link to custom pictures they want to use.

kartikcho avatar Jul 20 '20 14:07 kartikcho

I would like to work on this issue.

ExpressHermes avatar Jul 21 '20 04:07 ExpressHermes

Also the GH profile card is dependent on user data from Github to fill the blanks, adding Gravatar would require manual setup which I think should be added regardless of Gravatar so everyone can use the new contact section and link to custom pictures they want to use.

Ok then, what can be done is to create a section in portfolio.js for adding these and dump the old one. I will change the title of the issue and let this issue be adding custom images and text for the contact section which for now uses GitHub Profile. @ExpressHermes you can work on this issue and I am assigning you.😀

naveen521kk avatar Jul 21 '20 11:07 naveen521kk

Sounds awesome, it should also use the current Github implementation as it is already with the key to turn it on or off in portfolio.js. But then they could also opt-in for the old contact section with no picture. Hmm, should we just remove the old one or create a choice between the two sections with the added choice of choosing Github data @naveen521kk?

kartikcho avatar Jul 21 '20 18:07 kartikcho

We can have a option to select between the old and new one but whatever we do we need to document it. Like we need to tell about the switch in a comment or something so that the users understand it. Have the old contact section is better along with GitHub Profile and link to custom images.

naveen521kk avatar Jul 22 '20 03:07 naveen521kk

Hi guys! I'm willing to work on it... can someone assign it to me? Also, I understand you guys want to use gravatar as an option for devs to use their profile card.

warengonzaga avatar Oct 16 '20 08:10 warengonzaga

Tagging @kartikcho

warengonzaga avatar Oct 16 '20 08:10 warengonzaga

Awesome! @naveen521kk cheers!

warengonzaga avatar Oct 16 '20 08:10 warengonzaga

Hey @WarenGonzaga , just to make the objectives a bit clear, we don't intend to integrate Gravatar anymore. Instead, we want to use the Github Contact Card to create a manual setup card. This would involve adding a switch to use custom info for the card, link to a custom picture in place of the now fetched GitHub image and using custom content for the fields, all from portfolio.js. Lemme know if anything is a bit confusing and thanks again!

kartikcho avatar Oct 16 '20 10:10 kartikcho

hi @kartikcho the setting in portfolio.js should be a raw link for the image?

warengonzaga avatar Oct 17 '20 09:10 warengonzaga

As additional, @kartikcho what are the needed information to be show in the Github Profile Card?

warengonzaga avatar Oct 17 '20 09:10 warengonzaga

The setting in portfolio.js should be a raw link for the image?

Local link sounds good. For a placeholder you can link to any existing image in assets with a comment

what are the needed information to be show in the Github Profile Card?

All the existing fields displayed in the GH card should be available to tweak manually, ideally with a switch to not display some fields.

I apologize for not providing enough information like a wireframe or something to make the issue a bit more clear. Hope my comment helps!

kartikcho avatar Oct 17 '20 09:10 kartikcho

@kartikcho thanks I got this hehe

warengonzaga avatar Oct 18 '20 07:10 warengonzaga

Still working on this guys... thanks.

warengonzaga avatar Dec 16 '20 13:12 warengonzaga

No worries, thanks for picking it up!

kartikcho avatar Dec 17 '20 12:12 kartikcho

@WarenGonzaga are you still on this? It's alright if you're busy.

kartikcho avatar Feb 10 '21 19:02 kartikcho

hi @kartikcho sorry I'm currently busy if you're about to work on it its all good. I'm going to back to open source by March again.

warengonzaga avatar Feb 10 '21 19:02 warengonzaga

Oh it's alright @WarenGonzaga, hope you're doing okay 💜.

I'm not planning to pick this up myself, just make it available for someone else if they want to.

See you back in action soon!

kartikcho avatar Feb 10 '21 19:02 kartikcho

@kartikcho can I take this issue, please? anyone between this and #212 works for me. i would prefer solving both of them if that's acceptable for you

Rispectech avatar Oct 01 '21 09:10 Rispectech