rcarousel icon indicating copy to clipboard operation
rcarousel copied to clipboard

Widget namespace should be other than 'ui.'

Open rdworth opened this issue 13 years ago • 2 comments

The 'ui.' widget namespace is reserved for widgets that are part of the jQuery UI Suite (http://jqueryui.com/). It is intended that developers building their own widgets using the jQuery UI Widget Factory select their own namespace so as to avoid a collision with a current or future plugin of the same name in a suite maintained by a separate bunch of folks.

The fix is simple enough. On line https://github.com/ryrych/rcarousel/blob/master/widget/lib/jquery.ui.rcarousel.js#L2 just change 'ui' to a namespace of your choosing, such as 'r' or 'ry' or 'ryry' or 'ryrych' or something else entirely. Also, don't forget to update the filename to reflect the change. The filename should generally be jquery.namespace.widgetname.js

Thanks!

rdworth avatar Feb 15 '12 19:02 rdworth

Yes, I know. I read this text a few days ago. As I’m working now on a new version, this will be changed when it is released. Thanks.

ryrych avatar Feb 15 '12 20:02 ryrych

Oh, sorry. I thought it relates to rlightbox that I’m working on now. Anyway it will also be changed in rcarousel.

ryrych avatar Feb 15 '12 20:02 ryrych