github-profile-trophy icon indicating copy to clipboard operation
github-profile-trophy copied to clipboard
verified publisher icon ryo-ma

Change text of the points, and hide extra info for some special trophies

Open bhavberi opened this issue 2 years ago • 4 comments

  • Changed the text pt to meaningful for different trophies. The default text is still pt. (Related to issue https://github.com/ryo-ma/github-profile-trophy/issues/112)
  • Hide the points text and the rank bar for special trophies, which are, in a sense, binary to get. (For Example - Joined2020Trophy, where the points does not make sense)

bhavberi avatar Dec 03 '23 07:12 bhavberi

@bhavberi is attempting to deploy a commit to the ryo-ma's Team Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 03 '23 07:12 vercel[bot]

@AlexcastroDev Requesting your review and suggestions.

bhavberi avatar Dec 03 '23 07:12 bhavberi

@bhavberi I have some points here about the PR. For example missing unit test for this change, and logic inside return render.

But first of all, i need @ryo-ma to check if this change makes sense.

alexcastrodev avatar Dec 05 '23 15:12 alexcastrodev

Can you tell me exactly what tests you are referring to? The basic deno tests are already done, and I couldn't find any other tests specified in the repository.

bhavberi avatar Dec 05 '23 18:12 bhavberi

That modification is not acceptable because it may also extend beyond the drawing area.

ryo-ma avatar Mar 18 '24 12:03 ryo-ma