go-glob icon indicating copy to clipboard operation
go-glob copied to clipboard

question mark support

Open tuvia-akeyless opened this issue 2 years ago • 2 comments

Can you please add support for ? sign By definition, Glob supports * and ? Thanks.

tuvia-akeyless avatar May 23 '23 12:05 tuvia-akeyless

@cgaspar Hi! I understand that you'd like the library to support a more full-featured set of globbing characters. Admittedly, this library only implements exactly what I needed at the time that I wrote it, and nothing else. For the past 10 years it has served its purpose perfectly in many applications developed by HashiCorp as well as third party companies and other OSS users.

I would certainly be receptive to a feature request like @tuvia-akeyless exemplified nicely (thanks @tuvia-akeyless!). The way you chose to raise these shortcomings, however, is unacceptable, not just to me but for most OSS developers who donate their time to building freely available code. I humbly suggest that the next time you want to point out an issue with OSS code that you frame it in a constructive way, which will certainly play to your favor in terms of it actually being accepted and implemented by the maintainer.

ryanuber avatar Aug 06 '24 17:08 ryanuber

To clarify, this library was written as part of a personal project in 2014 before I joined HashiCorp. It was very much written in my spare time. This is why it's under my name, not the HashiCorp org. It turned out that it was useful at HashiCorp too, which is why it is imported into some of HC's projects.

My original suggestion stands - if you have anything constructive to offer, great! Otherwise, your concerns are noted, and I think we can leave it at that.

ryanuber avatar Aug 06 '24 17:08 ryanuber