react-frame-component icon indicating copy to clipboard operation
react-frame-component copied to clipboard
verified publisher icon ryanseddon

call onLoad given as Props

Open yukukotani opened this issue 3 years ago • 3 comments

Currently onLoad is overridden by handleLoad so does not works.

yukukotani avatar Aug 14 '22 13:08 yukukotani

We might need to rejig this once #207 merges as the logic moves away from onLoad to utilising DOMContentLoaded instead

ryanseddon avatar Aug 18 '22 23:08 ryanseddon

@ryanseddon oh I didn't notice that.

Or maybe we don't need this. We manually subscribe load event by addEventListener so it seems there is no reason to give onLoad props of iframe. Can we just remove onLoad props at line 139?

yukukotani avatar Aug 19 '22 01:08 yukukotani

@ryanseddon Sorry please forget the comment above, i misunderstood the logic.

I've added the commit 85b924e so that this PR won't conflict with #207.

yukukotani avatar Aug 19 '22 01:08 yukukotani