basque icon indicating copy to clipboard operation
basque copied to clipboard

Bug: Player easily falls out-of-bounds

Open fontire opened this issue 4 years ago • 8 comments

Moving vertically near the edge of a column of tiles allows the player to then move outside the bounds.

This should be solvable with standard bounding boxes.

fontire avatar Aug 26 '21 20:08 fontire

Yep, this is already solved in the closed source version of the engine as seen on the Twitch streams, but fixing it here is tricky while staying under 1000 lines.

ryanpcmcquen avatar Aug 26 '21 22:08 ryanpcmcquen

Is there a need to stay < 1000 lines? It's a nice number but having the engine more useful seems like a better goal.

fontire avatar Aug 26 '21 22:08 fontire

I'd rather make a 'Basque+' or something similar when the game is done with a host of improvements. I think the 'under 1000 lines' rule keeps it mentally manageable for people who are just getting into C99 and whatnot.

ryanpcmcquen avatar Aug 26 '21 22:08 ryanpcmcquen

Okay. Incidentally, I don't think that an UP/DOWN event combo in SDL2 has delay/repeat issues when storing the state (as in the changes in my fork).

The DOWN event triggers the state immediately and that is retained until the UP state (also immediate). Any delayed/repeated DOWN events have no effect on the state.

fontire avatar Aug 26 '21 22:08 fontire

Would you be willing to test the WASM port with these changes? I remember touch controls being weird there before scancodes.

ryanpcmcquen avatar Aug 26 '21 22:08 ryanpcmcquen

Perhaps. I don't think I'm set up for that, though.

fontire avatar Aug 26 '21 22:08 fontire

I think I can temporarily deploy your branch using GitHub actions and test it here, won't have time for a few days though ...

ryanpcmcquen avatar Aug 26 '21 22:08 ryanpcmcquen

@fontire will you make a PR here?

ryanpcmcquen avatar Jul 06 '22 00:07 ryanpcmcquen