Multiplayer icon indicating copy to clipboard operation
Multiplayer copied to clipboard

Remove String Method Names from Harmony Patches

Open Tick-git opened this issue 5 months ago • 2 comments

Labels: Enhancement, Good first issue

Some method names are still written as string literals instead of using nameof(Thing.Tick). This makes it harder to quickly locate patched methods.

It would be great to update all patches to consistently use the nameof convention.

Example:

https://github.com/rwmt/Multiplayer/blob/f0221d0488282629ebbdef7d58c9d4a93e393b85/Source/Client/MultiplayerStatic.cs#L376-L384

Tick-git avatar Aug 20 '25 12:08 Tick-git

Hi, I’d like to work on this issue. Can I be assigned?

CloudeaSoft avatar Aug 21 '25 08:08 CloudeaSoft

You don't need permission, go for it. The task is pretty simple, find Method names in strings and replace them with their nameof counterpart.

notfood avatar Aug 21 '25 16:08 notfood