github-webhook

github-webhook copied to clipboard

[The code](https://github.com/rvagg/github-webhook/blob/master/github-webhook.js#L206) pops the first element of an array in each execution and the length of the array is reduced by one each time when the webhook is triggered since...

ustc-zzzz

Hichamchamas

Hi, this is something i just added. I thought it was cool enough to PR it !

kapouer

Log unhandled events

1

It would be nice if an event where no rules matched would create a log entry.

gbirke

This fixes an issue with successive events and variable scope.

kapouer

Command executed twice

11

Is there any reason why the same command would be executed twice from a single event? In the logs, there's only a second difference between the two executions.

chrisjaure

I run `github-webhook` as PID 1 inside a Docker container and the process does not terminate cleanly when it receives a SIGTERM. If I understand well _node_ forwards the signals...

antoineco

Initially this is behind a terminator for me but I imagine it'd be common to want to expose it direct, in which case being able to specify the various keyfiles...

rvagg