walrus icon indicating copy to clipboard operation
walrus copied to clipboard

CI on master branch is broken

Open michael8090 opened this issue 3 years ago • 1 comments

Describe the Bug

The CI is broken on master branch, caused by some format mismatch in round_trip tests.

You can see the errors here: https://github.com/rustwasm/walrus/runs/7362687785?check_suite_focus=true

failures:
---- tests_round_trip_anyref2_wat stdout ----
thread 'tests_round_trip_anyref2_wat' panicked at 'CHECK failed!
Did not find pattern
    CHECK: (module
    NEXT: (type (;0;) (func (param i32) (result externref)))
    NEXT: (func (;0;) (type 0) (param i32) (result externref)
    NEXT: local.get 0
    NEXT: table.get 0)
    NEXT: (table (;0;) 1 externref)
    NEXT: (export "a" (func 0)))
in output
    (module
      (type (;0;) (func (param i32) (result externref)))
      (func (;0;) (type 0) (param i32) (result externref)
        local.get 0
        table.get 0
      )
      (table (;0;) 1 externref)
      (export "a" (func 0))
    )
', crates/tests/src/lib.rs:182:9

Note that the generated code has extra line breaks for some closing )s.

I think it has been broken for quite a while, as many PRs are blocked by the same CI failure.

Steps to Reproduce

Just trigger a CI and you can see it. Or you can run cargo test -p walrus-tests --test round_trip locally to reproduce (be sure to install bynaryen and wabt first).

michael8090 avatar Jul 15 '22 18:07 michael8090

https://github.com/rustwasm/walrus/pull/232

michael8090 avatar Jul 19 '22 04:07 michael8090