rustls
fix: rustls feature is now called `log`
see https://github.com/rustls/rustls/blob/main/rustls/Cargo.toml#L23
this feature was renamed in https://github.com/rustls/rustls/commit/192ab85a5c2c865b9cca9b2a8c987de33a102667, via https://github.com/rustls/rustls/pull/2549.
this updates the logging feature so that it now points to the new name of this feature.
this feature was renamed in https://github.com/rustls/rustls/commit/192ab85a5c2c865b9cca9b2a8c987de33a102667, via https://github.com/rustls/rustls/pull/2549.
I don't think the commit with that change has been published in a release yet, right?
see https://github.com/rustls/rustls/blob/main/rustls/Cargo.toml#L23
Since this repo is using rustls 0.23.x I think the right Cargo.toml to check is the one from rel-0.23, which still has logging:
https://github.com/rustls/rustls/blob/647ece13463bbb6eaf756146596fe182644424b1/rustls/Cargo.toml#L25
I don't think the commit with that change has been published in a release yet, right?
Correct.
rustls 0.23.* does actually have a feature called log (which doesn't enable its logging...) because cargo adds a feature for each optional dependency crate.
that's right! this rename is in main, but not yet released. my understanding that this will be going out as a part of a forthcoming 0.24 release. i'm happy to hold this as a draft until that has been released, but thought it'd be helpful to point out in advance.
I don't think the commit with that change has been published in a release yet, right?
Correct.
rustls 0.23.* does actually have a feature called
log(which doesn't enable its logging...) because cargo adds a feature for each optional dependency crate.
and this is also true! "rustls feature" felt like the most concise way to fit this in a pull request title, vs "implicitly added cargo feature for an optional dependency" :sweat_smile:
i'm happy to hold this as a draft until that has been released
Sounds good. Let's x-link with https://github.com/rustls/rustls/issues/2400 to help remember.