rcgen icon indicating copy to clipboard operation
rcgen copied to clipboard
verified publisher icon rustls

Eagerly implemented `PartialEq` and `Eq` traits

Open Rynibami opened this issue 9 months ago • 1 comments

Issue #340 discussed implementing the most common traits for this crate. I implemented the PartialEq and Eq traits for all possible stucts and enums in this PR. I included the derive for private key data as I thought that this would not leak any secret information. Please correct me if I'm wrong.

Rynibami avatar May 16 '25 17:05 Rynibami

I don't think we should implement these in rustls-cert-gen which I don't consider as having a public Rust API anyway.

djc avatar May 18 '25 11:05 djc

I don't think we should implement these in rustls-cert-gen which I don't consider as having a public Rust API anyway.

@djc I reverted all Eq and PartialEq I made to rustls-cert-gen. Are there more things that should be updated?

Rynibami avatar May 23 '25 11:05 Rynibami

Hey guys, I was wondering why this pull request hasn't been merged yet. Especially when I haven't seen any new opinions pop up. Do we need another review with an approval (from @cpu)? Or is there something else I can do?

Rynibami avatar Jun 18 '25 16:06 Rynibami