sm icon indicating copy to clipboard operation
sm copied to clipboard

Would it be reasonable to change pub(crate) to pub?

Open chotchki opened this issue 5 years ago • 2 comments

I'm having an issue where I have the state machine defined in a separate file:

main.rs <--- I want to use it here protocol/ protocol/client_sm.rs <---- sm! macro here.

However when I attempt to use it I get an error due to the macro's definition of everything as "pub(crate)".

I think this is an example of that: https://github.com/rustic-games/sm/blob/749d4df59f095327bad5836ca5594e98b3686481/sm_macro/src/sm/machine.rs#L17

Would you be open to a pull request moving it to just "pub"?

I'm also VERY new to rust so if I'm doing something wrong, please tell me!

Thank you!

chotchki avatar Sep 27 '20 01:09 chotchki

@chotchki did you find a solution to your problem? I'm in a similar position to you.

sjmackenzie avatar Jan 24 '21 16:01 sjmackenzie

@sjmackenzie my apologies just saw this in my inbox. I ended up not using the library and finding a way to avoid making an explicit state machine.

chotchki avatar Jun 17 '21 00:06 chotchki