rustdesk icon indicating copy to clipboard operation
rustdesk copied to clipboard

fix: sending file from local to remote

Open djex opened this issue 3 years ago • 6 comments

This fixes a bug where 0 byte files were being created when sending from local to remote.

djex avatar Nov 09 '22 17:11 djex

not accceptable, because send_raw is required for performance concern when sending big data in our ipc, but you can add a if

rustdesk avatar Nov 09 '22 23:11 rustdesk

Turns out this is my mistake. I was building a nightly build and not master. This issue is already fixed in the latest master.

djex avatar Nov 10 '22 04:11 djex

@djex i misunderstood your issue, you are correct, your fix is fine, but it destroy our optimization, send_raw is added for performance optimization, wondering if you have interest to fix the problem without removing send_raw?

rustdesk avatar Nov 15 '22 02:11 rustdesk

@Heap-Hop

rustdesk avatar Nov 15 '22 02:11 rustdesk

#2099

rustdesk avatar Nov 15 '22 02:11 rustdesk

both sciter and flutter has the same issue, it may be caused by our code refactory when migrating from sciter to flutter about two month ago.

rustdesk avatar Nov 15 '22 02:11 rustdesk

@Heap-Hop take over please

rustdesk avatar Nov 16 '22 01:11 rustdesk

i will merge this as a workaround

rustdesk avatar Nov 16 '22 01:11 rustdesk